Docker fix#33
Open
LinusOP wants to merge 2 commits intoCodingGarden:masterfrom
LinusOP:docker-compose-fix
Open
Docker fix#33LinusOP wants to merge 2 commits intoCodingGarden:masterfrom LinusOP:docker-compose-fix
LinusOP wants to merge 2 commits intoCodingGarden:masterfrom
LinusOP:docker-compose-fix
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no point mounting the node_modules as our Dockerfile tells docker to install all modules from our package.json, using the local ones instead of the ones in the container can cause problems.
Also replaced the install command with
npm ciand added&& npm cache clean --forceto not bloat the image with the cache after installation (as suggested by docd27 in the discord).I have tested and the containers still spin up fine without mounting the node folders.
(My first ever PR on github so hopefully i didn't do it wrong 😛)