Add unit tests and type definitions for Diffbot knowledge connectors#883
Closed
Copilot wants to merge 1 commit intodiffbot-webcrawler-unit-testingfrom
Closed
Add unit tests and type definitions for Diffbot knowledge connectors#883Copilot wants to merge 1 commit intodiffbot-webcrawler-unit-testingfrom
Copilot wants to merge 1 commit intodiffbot-webcrawler-unit-testingfrom
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Copilot
AI
changed the title
[WIP] Add unit tests for Diffbot webcrawler
Add unit tests and type definitions for Diffbot knowledge connectors
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unit test coverage and TypeScript type definitions for the Diffbot webcrawler and webpage knowledge connectors, which previously had none.
Type definitions (
types.ts)CrawlJobSettings,DiffbotResult,DiffbotJobStatus,DiffbotCrawlJob,DiffbotCreateCrawlResponse,DiffbotJobStatusResponseDiffbotArticle,DiffbotV3AnalyzeResponse,DiffbotRequest,DiffbotImage,DiffbotTag,DiffbotBreadcrumb,DiffbotCategoryUnit tests —
diffbotCrawlerConnectorupsertKnowledgeSourcereturnsnull(content unchanged)retainCrawler: truesuppresses job deletionpageUrlare skippedUnit tests —
diffbotWebpageConnectorexternalIdentifiernullobjectsarrayAll tests use Node.js built-in
node:test+mock.fn/mock.method, consistent with the rest of the repo.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.