Skip to content

Conversation

@alien1976
Copy link
Collaborator

Build procedure now build test UI in production instead of vite dev mode which leads to instant load of the UI. Drag tests are fixed with the new gameface e2e 2.3.0 methods. Fixed the other failing tests

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the E2E testing workflow to run against a production build (via vite build + vite preview) and adjusts failing tests to use newer gameface-e2e APIs.

Changes:

  • Switch Vite config to use mode for selecting the test vs prod UI root and make build output deterministic.
  • Update E2E specs to use updated interaction APIs (e.g., dragBy, mouseMove) and add small stability tweaks.
  • Update test scripts/config to build the test UI and run against a preview server with a longer spec timeout.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
vite.config.mts Uses Vite mode to target test views and refines build output settings.
package.json Updates gameface-e2e version and changes test scripts to build + preview for faster/stabler loading.
tests/gameface-e2e-config.js Adds typing hint and increases per-spec timeout.
tests/specs/xy-slider.spec.js Migrates drag interaction to dragBy.
tests/specs/text-slider.spec.js Migrates drag interaction to dragBy.
tests/specs/slider.spec.js Migrates drag interaction to dragBy.
tests/specs/scroll.spec.js Migrates handle drag interaction to dragBy with updated deltas.
tests/specs/radial-menu.spec.js Migrates mouse movement calls to mouseMove.
tests/specs/color-picker.spec.js Migrates drag interaction to dragBy and adjusts drag deltas; adds JSDoc typedef.
tests/specs/checkbox.spec.js Migrates mouse movement calls to mouseMove.
tests/specs/carousel.spec.js Adds scrollToTop() to stabilize the “change items width” test.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Build procedure now build test UI in production instead of vite dev mode which leads to instant load of the UI. Drag tests are fixed with the new gameface e2e 2.3.0 methods. Fixed the other failing tests
@alien1976 alien1976 merged commit d6a688e into master Jan 27, 2026
1 check passed
@alien1976 alien1976 deleted the fix/drag-tests branch January 27, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants