updating with CLI changes for skeleton, and legacy errors for migration lambda#10
Open
pjaol wants to merge 2 commits intoCollaborne:masterfrom
Open
updating with CLI changes for skeleton, and legacy errors for migration lambda#10pjaol wants to merge 2 commits intoCollaborne:masterfrom
pjaol wants to merge 2 commits intoCollaborne:masterfrom
Conversation
…rrors controlling migration lambda
Contributor
|
Do you have a reference why the changes to the skeleton are needed? It looks like you're just moving around a parameter -- not bad, and probably easier to work with, but would like to have a bit of rationale here. |
ankon
reviewed
May 10, 2022
ankon
suggested changes
May 12, 2022
Contributor
ankon
left a comment
ankon
left a comment
There was a problem hiding this comment.
Can you add a fixup to the paragraph with the edits you suggested? Other than that: LGTM, thanks!
Contributor
Author
|
Hi @ankon I've finally gotten around to making the update - let me know if there's anything else you see that I should change. Thank you for the feedback! |
ankon
approved these changes
May 18, 2022
Contributor
ankon
left a comment
ankon
left a comment
There was a problem hiding this comment.
I think this is fine, thanks!
|
Thanks for this. These changes are needed for the CLI instructions - they fail otherwise. It would be great to merge this for future users. Thanks again |
Contributor
|
@ronnyroeller PTAL :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updating with CLI changes for skeleton, and README about cognito security configuration > legacy errors controlling migration lambda execution.