Countries api #22
Open
Countries api #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and by search, and add func of change to dark mode - react actions
Tamir198
requested changes
Jan 4, 2025
Member
Tamir198
left a comment
Tamir198
left a comment
There was a problem hiding this comment.
Please remove all of the logs that you have
Other than that I left you come comments
| right: 0.4rem; | ||
| background: none; | ||
| /* border: none; */ | ||
| border-color:white; |
| justify-content: center; | ||
| align-items: center; | ||
| z-index: 1000; | ||
| } |
Member
There was a problem hiding this comment.
Can you use lower z-index number?
| <div>Country</div> | ||
| ) | ||
| } | ||
| <div className="country scale-effect" onClick={onClick}> |
Member
There was a problem hiding this comment.
Good job here on destruct the props
| <ul className="country-brief"> | ||
| <li><strong>Population: </strong>{population}</li> | ||
| <li><strong>Region: </strong>{region}</li> | ||
| <li><strong>Capital: </strong>{capital}</li> |
Member
There was a problem hiding this comment.
Do not use the strong tag, add style via css
| <div className="search-wrapper"> | ||
| <i className="fa-regular fa-magnifying-glass search-icon"></i> | ||
| <input type="text" class="search-input" placeholder="Search for a country..." onInput={()=>props.filterBySearchFunc(event)}/> | ||
| </div> |
Member
There was a problem hiding this comment.
If you destruct your props you would not need to do this via props.
|
|
||
| const Modal = ({ selectedCountry, isOpen, onClose }) => { | ||
| if (!isOpen) return null; | ||
| const { name, flags, population, region, capital } = selectedCountry; |
Member
There was a problem hiding this comment.
This is a component, explain why do you return null and not jsx
| .then((data)=>{ | ||
| console.log(data); | ||
| setfilteredArray(data); | ||
| setOriginalArray(data); |
| console.log(region); | ||
|
|
||
| if(region==="All"){ | ||
| setfilteredArray(originalArray); |
| document.body.classList.toggle("dark-theme", !isDarkMode); | ||
| } else { | ||
| document.body.classList.remove("dark-theme"); | ||
| } |
Member
There was a problem hiding this comment.
Why do you need the else in here? toggle will take care of the class name wont it ?
| </main> | ||
| <Modal | ||
| selectedCountry={selectedCountry} //props | ||
| isOpen={isModalOpen} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i added a commit about the modal, whaiting for pr :)