pr for my commits #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and by search, and add func of change to dark mode - react actions
Tamir198
requested changes
Dec 27, 2024
Member
Tamir198
left a comment
Tamir198
left a comment
There was a problem hiding this comment.
Good work generally left you some comments
src/components/Country.jsx
Outdated
| return ( | ||
| // TODO: Country component | ||
| <div>Country</div> | ||
| <> |
Member
There was a problem hiding this comment.
Destruct your props, you can even do :
const Country = ({name, flag , etc...}) => {
| <input type="text" class="search-input" placeholder="Search for a country..." onInput={()=>props.filterBySearchFunc(event)}/> | ||
| </div> | ||
| <div className={`dropdown-wrapper ${isOpen ? "open" : ""}`}> | ||
| <div className="dropdown-header flex flex-jc-sb flex-ai-c" onClick={openDropDown}> |
Member
There was a problem hiding this comment.
Here is a shorter syntax :
<div className={`dropdown-wrapper ${isOpen && "open"}`}>
src/pages/Home.jsx
Outdated
| const matchValue = (country,input) =>{ | ||
| return country.name.toLowerCase().includes(input) || | ||
| country.population.toString().includes(input) || | ||
| country.region.toLowerCase().includes(input) || |
Member
There was a problem hiding this comment.
includes is array function so you could do it like this :
const matchValue = (country, input) =>
[country.name, country.population.toString(), country.region, country.capital]
.some(value => value.toLowerCase().includes(input.toLowerCase()));And if you destruct card it will be even shorter
|
|
||
| if (!isDarkMode) { | ||
| document.body.classList.add("dark-theme"); | ||
| } else { |
Member
There was a problem hiding this comment.
You can use the second argument of classllist.toggle method to add a condition and make this shorter :
document.body.classList.toggle("dark-theme", !isDarkMode);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding country cards by import from the jsonData, filter it by region and by search, and add func of change to dark mode - react actions