Lian calculator js #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GilHeller
requested changes
Dec 8, 2024
Contributor
GilHeller
left a comment
GilHeller
left a comment
There was a problem hiding this comment.
Overall nice job!
please see my comments
| let tipAmout; | ||
| let total; | ||
|
|
||
| calcTip= (x) =>{ |
Contributor
There was a problem hiding this comment.
declare as a const. Also, give x a meaningful name
const calcTip = (x) => {
...
}
Comment on lines
+27
to
+28
| tipAmountResult.innerText="$"+tipAmount.toFixed(2); | ||
| totalAmountResult.innerText="$"+total.toFixed(2); |
Contributor
There was a problem hiding this comment.
consider using createElement and appendChildinstead ofinnerHTML`
innerHTML has security vulnerability.
| .ptags { | ||
| padding-bottom: 30px; | ||
| font-weight: 900; | ||
| color: hsl(186, 14%, 43%); |
Contributor
There was a problem hiding this comment.
use css variables
see https://www.w3schools.com/css/css3_variables.asp
| flex-direction: column; | ||
| justify-content: flex-start; | ||
| align-items: flex-start; | ||
| /* padding-left: 30px; */ |
Comment on lines
+36
to
+47
| if(!customValue || customValue<=0){ | ||
| hoverWarning.style.display="block"; | ||
| return; | ||
| } | ||
| hoverWarning.style.display="none"; | ||
|
|
||
| tipAmount=(priceValue*customValue)/peopleValue; | ||
| total=(priceValue*(1+customValue))/peopleValue; | ||
|
|
||
|
|
||
| tipAmountResult.innerText="$"+tipAmount.toFixed(2); | ||
| totalAmountResult.innerText="$"+total.toFixed(2); |
Contributor
There was a problem hiding this comment.
This section repeating. Consider extract it to a function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finished js