done html,css,js #28
Open
done html,css,js #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GilHeller
requested changes
Dec 7, 2024
Contributor
GilHeller
left a comment
GilHeller
left a comment
There was a problem hiding this comment.
Overall nice job!
please see my comments
| / person | ||
| <div class="tip-amount-container"> | ||
| <div class="flex-box-tip"> | ||
| <p>Tip amount<br><span style="color:hsl(184, 14%, 56%)">/ person</span></p> |
Contributor
There was a problem hiding this comment.
Why did you use inline styling instead of a class and css?
This can cause a mixed style dependencies. pick on styling method and stick with it.
|
|
||
| // הצגת התוצאה בתיבה | ||
| document.getElementById('total-amount-input').value = `$${result}`; | ||
| console.log("bill amount:", billAmount, "num of ppl:", howManyPpl, "tip:", tipPercentage, "result:", result); // הדפסת הערכים בקונסול |
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| background-color: hsl(185, 41%, 84%); |
Contributor
There was a problem hiding this comment.
use css variables
| const totalWithTip = billAmount * (1 + tipPercentage); | ||
| const result = howManyPpl > 0 ? (totalWithTip / howManyPpl).toFixed(2) : 0; | ||
|
|
||
| // הצגת התוצאה בתיבה |
Contributor
There was a problem hiding this comment.
Avoid writing comments in Hebrew.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.