Online store task - Asher Pe'er #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tamir198
requested changes
Dec 11, 2025
Member
Tamir198
left a comment
Tamir198
left a comment
There was a problem hiding this comment.
Good work, left you some comments
| ) /* : add return types */ { | ||
| return []; | ||
| function getProductsByTag( store : Store , tag : string[] ) : Product[] { | ||
| return store.products.filter(product => tag.some(tg => product.tags.includes(tg))); |
Member
There was a problem hiding this comment.
Can yo explain why do you have the some method in here?
You are not wrong, just wanted to hear your opinion
| ) /* : add return types */ { | ||
| return []; | ||
| function getCartProducts(store : Store , cart : number[] ) : Product[] { | ||
| return cart.flatMap(productId => store.products.filter(product => product.id === productId)); |
Member
There was a problem hiding this comment.
Cart is an array of numbers, what good is the flatMap in here?
| return 0; | ||
| function getCartTotalInStock( store : Store, cart : number[]) : number { | ||
| let total = 0; | ||
| for(const id of cart){ |
Member
There was a problem hiding this comment.
This is fine, try to use reduce function in here
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/reduce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.