Skip to content

S3 logging #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
j4y merged 2 commits into from
Dec 26, 2025
Merged

S3 logging #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed8f892
feat: enable S3 and CloudFront access logging
j4y Dec 26, 2025
af83535
fix(tflint): replace deprecated `module` attribute with `call_module_…
j4y Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .tflint.hcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ config {
disabled_by_default = false
format = "compact"
force = false
module = true
call_module_type = "all"
}

plugin "aws" {
enabled = true
source = "github.com/terraform-linters/tflint-ruleset-aws"
Expand Down
18 changes: 18 additions & 0 deletions terraform/website/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,17 @@
bucket = var.domain
}

resource "aws_s3_bucket_logging" "bucket_logging" {
bucket = aws_s3_bucket.bucket.id

target_bucket = aws_s3_bucket.logs.id
target_prefix = "s3-access-logs/"
}

resource "aws_s3_bucket" "logs" {
bucket = "${var.domain}-logs"
}

resource "aws_s3_bucket_ownership_controls" "bucket" {
bucket = aws_s3_bucket.bucket.id
rule {
Expand Down Expand Up @@ -70,6 +81,13 @@
is_ipv6_enabled = true
price_class = "PriceClass_100"

logging_config {
include_cookies = false
bucket = "${aws_s3_bucket.logs.bucket_regional_domain_name}"

Check warning on line 86 in terraform/website/main.tf

View workflow job for this annotation

GitHub Actions / test 

Interpolation-only expressions are deprecated in Terraform v0.12.14
prefix = "cloudfront/"
}


origin {
domain_name = aws_s3_bucket_website_configuration.bucket.website_endpoint
origin_id = aws_s3_bucket.bucket.bucket_regional_domain_name
Expand Down
Loading