BEHAVIOR: use single square root in PhaseSpaceFactor
#484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redeboer
added
📝 Docs
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
* FEAT: define `BreakupMomentumSplitSqrt` and `BreakupMomentumKallen` * MAINT: standardize docstring extension of phasespace factor protocols
redeboer
changed the title
PhaseSpaceFactor
redeboer
force-pushed
the
ENH/select-split-sqrt
branch
from
3950d14 to
30a966b
Compare
redeboer
added a commit
to ComPWA/polarimetry
that referenced
this pull request
Oct 28, 2025
redeboer
added a commit
to ComPWA/polarimetry
that referenced
this pull request
Oct 28, 2025
redeboer
added a commit
to ComPWA/polarimetry
that referenced
this pull request
Oct 29, 2025
redeboer
added a commit
to ComPWA/polarimetry
that referenced
this pull request
Oct 29, 2025
* FIX: always restore `output-files` cache
Zeyna777
requested changes
Oct 29, 2025
Contributor
Zeyna777
left a comment
Zeyna777
left a comment
There was a problem hiding this comment.
Explain motivation for this. What is the message for the user? What sqrt is now better to use? Do we even care about 'less complex' cut structure below 1st threshold when this should be solved by using Chew Mandelstam anyway?
Member
Author
|
I added a bit of explanation in 1421f1a. Was tempted to explain more about analyticity, but this is better addressed through https://github.com/ComPWA/RUB-EP1-Fritsch/issues/121. |
Zeyna777
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #483
Tip
Preview of the page about analytic continuation here.
The phase space factor and break-up momentum with a "split" square root have a cleaner cut structure, but have worse numerical performance. This PR therefore reverts #479 and offers the alternative functions
PhaseSpaceFactorKallenandPhaseSpaceFactorSplitSqrt.