fix: reject zero address in owner and transfer fields (#140)#173
Conversation
|
@1nonlypiece, please review and merge |
|
@edehvictor resolve the conflicts |
edehvictor
left a comment
There was a problem hiding this comment.
Fix the compile error
edehvictor
left a comment
There was a problem hiding this comment.
fix is_zero_address function error
edehvictor
left a comment
There was a problem hiding this comment.
Fix the compile error
edehvictor
left a comment
There was a problem hiding this comment.
Fix compile error
edehvictor
left a comment
There was a problem hiding this comment.
fixing the compile error
edehvictor
left a comment
There was a problem hiding this comment.
fixing the compile error
edehvictor
left a comment
There was a problem hiding this comment.
fix test.rs file
|
@edehvictor resolve the conflicts & fix the pipeline |
|
@1nonlypiece, I have merge conflict. kindly review |
|
please resolve the conflicts |
|
Gm @1nonlypiece, I have resolved conflict. Kindly merge |
|
@1nonlypiece, please kindly review. We're less than two hours to the end of Wave 2 I have resolved conflict |
Overview
This PR addresses Issue #140 by implementing simulated "Zero Address" rejection. It explicitly checks for the Stellar null address (
GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF) and prevents it from being used as an owner or transfer recipient.Changes Made
commitment_coreis_zero_addresshelper function.create_commitmentto reject zero addresses as the owner.ZeroAddressvariant to theCommitmentErrorenum.test_create_commitment_zero_address_failsunit test.commitment_nftis_zero_addresshelper function.mintfunction to reject zero addresses as the owner.transferfunction to reject zero addresses as the recipient (to).test_mint_to_zero_address_failsandtest_transfer_to_zero_address_failsunit tests usingshould_panicwith theTransferToZeroAddress(error code 18).Closes #140