feat(commitment): document and test semantics of commitment types#184
Merged
1nonlypiece merged 6 commits intoCommitlabs-Org:masterfrom Feb 26, 2026
Merged
Conversation
Contributor
Author
|
@1nonlypiece done..thank you |
Contributor
|
please resolve the conflicts |
Contributor
Author
|
@1nonlypiece done |
Contributor
Author
|
@1nonlypiece please can you help me check this pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
##Description
Documented and formalized the semantics of commitment types (safe, balanced, aggressive), defining allocation rules, pool eligibility, risk exposure, and penalty differences. Added tests ensuring each type enforces its constraints (allocation limits, pool usage, early exit behavior). Ensures behavior is explicit, validated, and regression-safe.
closes #151