test: add zero address validation tests for transfer and owner (#140)#194
Merged
1nonlypiece merged 7 commits intoCommitlabs-Org:masterfrom Feb 26, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #140
This PR introduces comprehensive test coverage to ensure that zero/invalid addresses are properly rejected across the core and NFT contracts. Since Soroban does not have a native "zero address," these tests utilize a 32-byte array of zeroes to mock an invalid address execution environment.
Changes Made
contracts/commitment_nft): - Addedtest_zero_address.rs.test_nft_mint_to_zero_address_failsto verifymintpanics on a zero address.test_nft_transfer_to_zero_address_failsto verifytransferpanics whentois a zero address.contracts/commitment_core): - Addedtest_zero_address.rs.test_create_commitment_zero_owner_failsto verifycreate_commitmentpanics whenowneris a zero address.lib.rsfiles.Testing Instructions
To verify these tests pass locally, run the following commands from the root directory: