Add Support for `NavigationBar.SetColor(Color)` on Android 35+ #3057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

TheCodeTraveler merged 4 commits into main from Fix-NavigationBar-on-Android-35

Jan 30, 2026

Collaborator

TheCodeTraveler commented Jan 30, 2026 •

edited

Loading

Description of Change

This PR adds support for NavigationBar.SetColor(Color) on Android 35+.

This bug was introduced in Android 35+ when they deprecated the Window.SetNavigationBarColor() API that we were using to set the Navigation Bar Color:

Maui/src/CommunityToolkit.Maui/PlatformConfiguration/AndroidSpecific/NavigationBar.android.cs

Line 100 in a63844e

window.SetNavigationBarColor(color);

Linked Issues

Fixes [BUG] Android 35+: NavigationBar.SetColor has no effect #3056

PR Checklist

Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
Has samples (if omitted, state reason in description)
Rebased on top of main at time of PR
Changes adhere to coding standard

Additional information

This demo shows it now working on an Android API 36.1 Emulator:

The fix for this is similar to the 35.0+ bug fixed for StatusBar in #2939

TheCodeTraveler added 2 commits

January 30, 2026 09:41


          Fix SetColor

6ff1ebf


          Update NavigationBar.android.cs

f61bd8d

TheCodeTraveler requested review from VladislavAntonyuk and Copilot

January 30, 2026 09:53

Copilot started reviewing on behalf of TheCodeTraveler

January 30, 2026 10:11

Copilot AI reviewed

View reviewed changes

Contributor

Copilot AI left a comment

Pull request overview

This PR fixes a bug where NavigationBar.SetColor() has no effect on Android 35+. The issue was introduced when Android deprecated the Window.SetNavigationBarColor() API in version 35. The fix follows the same pattern used for the StatusBar fix in PR #2939 by creating an overlay view for Android 35+ devices.

Changes:

Added Android 35+ support by creating a navigation bar overlay view when the deprecated API is unavailable
Added required Android.Widget import for FrameLayout usage
Maintained backward compatibility with Android 23-34 using the original API

src/CommunityToolkit.Maui/PlatformConfiguration/AndroidSpecific/NavigationBar.android.cs Outdated Show resolved Hide resolved


          Fix naming

00d2629

TheCodeTraveler requested a review from Copilot

January 30, 2026 10:21

Copilot started reviewing on behalf of TheCodeTraveler

January 30, 2026 10:21

Copilot AI reviewed

View reviewed changes

Contributor

Copilot AI left a comment

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

src/CommunityToolkit.Maui/PlatformConfiguration/AndroidSpecific/NavigationBar.android.cs Show resolved Hide resolved

src/CommunityToolkit.Maui/PlatformConfiguration/AndroidSpecific/NavigationBar.android.cs

+              				navigationBarOverlay = new(activity)
+              				{
+              					LayoutParameters = new FrameLayout.LayoutParams(Android.Views.ViewGroup.LayoutParams.MatchParent, navigationBarPixelSize + 3)

Copilot AI Jan 30, 2026

The magic number + 3 added to the navigation bar height is unexplained. Consider extracting this to a named constant with a descriptive comment explaining why 3 extra pixels are needed. This would improve code maintainability and make the intent clear to future developers.

Copilot uses AI. Check for mistakes.

src/CommunityToolkit.Maui/PlatformConfiguration/AndroidSpecific/NavigationBar.android.cs Show resolved Hide resolved


          Update src/CommunityToolkit.Maui/PlatformConfiguration/AndroidSpecifi…

595e1b1

…c/NavigationBar.android.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings

January 30, 2026 10:30

Copilot started reviewing on behalf of TheCodeTraveler

January 30, 2026 10:30

Copilot AI reviewed

View reviewed changes

Contributor

Copilot AI left a comment

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

src/CommunityToolkit.Maui/PlatformConfiguration/AndroidSpecific/NavigationBar.android.cs

Comment on lines +99 to 131

+              		if (OperatingSystem.IsAndroidVersionAtLeast(35))
+              		{
+              			const string navigationBarOverlayTag = "NavigationBarOverlay";
+              			WindowCompat.SetDecorFitsSystemWindows(window, false);
+              			var decorGroup = (ViewGroup)window.DecorView;
+              			var navigationBarOverlay = decorGroup.FindViewWithTag(navigationBarOverlayTag);
+              			if (navigationBarOverlay is null)
+              			{
+              				var navigationBarHeight = activity.Resources?.GetIdentifier("navigation_bar_height", "dimen", "android") ?? 0;
+              				var navigationBarPixelSize = navigationBarHeight > 0 ? activity.Resources?.GetDimensionPixelSize(navigationBarHeight) ?? 0 : 0;
+              				navigationBarOverlay = new(activity)
+              				{
+              					LayoutParameters = new FrameLayout.LayoutParams(Android.Views.ViewGroup.LayoutParams.MatchParent, navigationBarPixelSize + 3)
+              					{
+              						Gravity = GravityFlags.Bottom
+              					}
+              				};
+              				navigationBarOverlay.Tag = navigationBarOverlayTag;
+              				decorGroup.AddView(navigationBarOverlay);
+              				navigationBarOverlay.SetZ(0);
+              			}
+              			navigationBarOverlay.SetBackgroundColor(color);
+              		}
+              		else if (OperatingSystem.IsAndroidVersionAtLeast(23))
               		{
               			window.SetNavigationBarColor(color);
               		}

Copilot AI Jan 30, 2026

The NavigationBar implementation is missing window flag handling for transparent colors that StatusBar includes (StatusBar.android.cs:75-85). StatusBar sets different WindowManagerFlags based on whether the color is transparent:

For transparent: ClearFlags(DrawsSystemBarBackgrounds) and SetFlags(LayoutNoLimits)
For non-transparent: ClearFlags(LayoutNoLimits) and SetFlags(DrawsSystemBarBackgrounds)

Without this handling, transparent navigation bar colors may not render correctly. Consider adding similar logic to maintain consistency with StatusBar behavior and ensure proper transparent color support.

Copilot uses AI. Check for mistakes.

src/CommunityToolkit.Maui/PlatformConfiguration/AndroidSpecific/NavigationBar.android.cs

+              		if (OperatingSystem.IsAndroidVersionAtLeast(35))
+              		{
+              			const string navigationBarOverlayTag = "NavigationBarOverlay";

Copilot AI Jan 30, 2026

This line has trailing whitespace after the semicolon. Remove the trailing whitespace to maintain code cleanliness.

Suggested change

Copilot uses AI. Check for mistakes.

VladislavAntonyuk approved these changes

View reviewed changes

TheCodeTraveler enabled auto-merge (squash)

January 30, 2026 10:38

TheCodeTraveler merged commit cdf9fa5 into main

15 of 16 checks passed

TheCodeTraveler deleted the Fix-NavigationBar-on-Android-35 branch

January 30, 2026 10:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet