feat(pumpkin-core): Crash if a propagator constructor does not register anything #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImkoMarijnissen
approved these changes
Dec 16, 2025
ImkoMarijnissen
deleted the
feat/constructor-fails-on-no-registration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a
PropagatorConstructorimplementation does not register the propagator to be enqueued for any events, the propagator will never be enqueued except for when it is added to theState. In most cases, this is a programming error where someone forgets to call register.To make it more difficult for this error to occur, the propagator constructor context will now crash if it is dropped without any registration having taken place. In the odd case where no registration is done intentionally,
PropagatorConstructorContext::will_not_register_for_any_eventscan be called to avoid the crash.