THE-11: define and enforce popup/script performance budgets#75
Merged
ConduciveMammal merged 2 commits intocodex/theme-explorer-v2from Feb 12, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes THE-11 by adding enforceable performance budgets for extension footprint and popup load timing, and by wiring those checks into release QA.
New checks
1) Static footprint budget check
Script:
scripts/qa/check-performance-budget.jsWhat it validates from the production build (
build-vite):popupJsBytespopupCssBytespopupAssetBytespopupFootprintBytescontentScriptBytesinjectScriptBytesbackgroundScriptBytesBehaviour:
config/performance-budget.json2) Popup render-time budget check
Script:
scripts/qa/check-popup-render-time.jsHow it works:
build-vitelocallysrc/pages/Popup/index.htmldata-theme-explorer-popup-first-render-msfrom the rendered DOMBehaviour:
popupFirstRenderMsagainst budget inconfig/performance-budget.jsonRuntime instrumentation
src/pages/Popup/Popup.jsxnow records first terminal render duration and exposes it as:window.__THEME_EXPLORER_PERF__.popupFirstRenderMsdata-theme-explorer-popup-first-render-mson<html>QA / CI integration
package.jsonqa:performancenow runs both checks:check-performance-budget.jscheck-popup-render-time.jsqa:verify-buildinvokesqa:performance.github/workflows/qa-release-candidate.ymlbrowser-actions/setup-chrome@v1)CHROME_PATHinto QA step for deterministic CI executionDocumentation updates
docs/qa/performance-budget.mddocs/qa/release-checklist.mddocs/qa/release-pipeline.mdValidation performed
npm run build:prodnpm run qa:performancenpm run qa:verify-buildAll checks passed locally on commit
b734255.