Skip to content

Conversation

@arreyder
Copy link

@arreyder arreyder commented Jan 17, 2026

Summary

Changes these logs from Warn to Debug level:

  • sso_user.go:67 - "failed to get user status from scim"
  • iam_user.go:153 - "Error listing access keys"
  • iam_user.go:161 - "Error getting access key last used"

Why

These are non-fatal errors that don't block sync - we continue processing other users/keys. The code handles these errors gracefully (falls back to default values) and sync completes successfully.

Since these errors are expected in certain conditions (permission issues, access key configurations) and don't impact sync outcomes, Debug level is more appropriate.

Combined these were generating ~19K warn logs per 6 hours in production.

Test plan

  • Build passes
  • Deploy and verify log volume reduction

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Adjusted logging levels during IAM and SSO user operations for improved diagnostic clarity.

✏️ Tip: You can customize this high-level summary in your review settings.

Changes these logs from Warn to Debug level:
- sso_user.go: "failed to get user status from scim"
- iam_user.go: "Error listing access keys"
- iam_user.go: "Error getting access key last used"

These are non-fatal errors that don't block sync - we continue
processing other users/keys. Since sync completes successfully despite
these errors, Debug level is more appropriate.

Combined these were generating ~19K warn logs per 6 hours.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@arreyder arreyder requested a review from a team January 17, 2026 16:39
@coderabbitai
Copy link

coderabbitai bot commented Jan 17, 2026

Walkthrough

The pull request adjusts logging severity levels in error handling paths across two connector files, changing error log statements from Warn to Debug level without modifying control flow, behavior, or function signatures.

Changes

Cohort / File(s) Summary
Logging Level Adjustments
pkg/connector/iam_user.go, pkg/connector/sso_user.go
Changed error log statements from Warn to Debug level in getLastLogin (2 statements) and List (1 statement). No control flow or behavioral changes; reduced alerting verbosity for error conditions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A whisper instead of a shout,
We log our concerns with less clout,
Debug lines so fine,
Make errors less whine,
The connector runs cleaner throughout! 🌿

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately and concisely describes the main change: lowering log levels from Warn to Debug for non-fatal API errors.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants