Avoid overriding specific Content-Type and Accept headers

[shackra]

For some APIs, like Share Point REST API, providing additional information on the Content-Type can determine if the request fails or success (given that the actual content is what the API expects). This change prevents the SDK from blindly overwriting values for those two headers.

Summary by CodeRabbit

• Bug Fixes

  • Improved handling of Content-Type and Accept headers when composing requests with JSON bodies: custom header values that include parameters (e.g., charset or vendor params) are preserved appropriately while default JSON headers are applied as needed.

• Tests

  • Added tests confirming requests with custom Content-Type or Accept headers plus JSON body options produce the expected method, URL, headers, and JSON-encoded body.

[coderabbitai]

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9fbefb7 and e16255c.

📒 Files selected for processing (1)

• pkg/uhttp/wrapper.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Cursor Bugbot

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[shackra]

@ggreer I can't assign reviewers for this PR, so, can you review this? 😬

[shackra]

El martes 26 de agosto del 2025, cursor[bot] escribió:

@cursor[bot] commented on this pull request. The special handling for Content-Type and Accept headers has two issues. The logic's case-sensitive map access can prevent existing headers from being found, leading to duplicate logical headers.

you mean, like having `Content-Type` there and then setting `content-type` on the map? well, that could be a problem, yes.

Also, it only updates these headers if the new value contains a semicolon, silently ignoring explicit overrides with simpler values.

that's the point, my binary friend, as that was the previous behavior (always overwriting the values)

…

-- Jorge Araya Contacto: Telegram: t.me/shackra · Signal: Shackra.28