Limit max attempts for validate

[mbburch]

This PR adds a limit for retries for Validate.

Summary by CodeRabbit

• Bug Fixes
  • Limited the number of validation retries to 5 attempts, preventing indefinite retry loops during validation errors.

[coderabbitai]

Walkthrough

The retry logic in the Validate method of the builderImpl struct has been updated to limit the number of validation retries to 5, instead of allowing infinite retries. The delay settings remain unchanged, affecting how validation errors are retried within the method.

Changes

Cohort / File(s)	Change Summary
Retry Configuration Update pkg/connectorbuilder/connectorbuilder.go	Changed retryer configuration in builderImpl.Validate method: MaxAttempts set from 0 (infinite) to 5.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant builderImpl
    participant Retryer

    Client->>builderImpl: Call Validate(request)
    loop Up to 5 attempts
        builderImpl->>Retryer: Attempt validation
        alt Validation fails
            Retryer-->>builderImpl: Retry (with delay)
        else Validation succeeds
            Retryer-->>builderImpl: Success
        end
    end
    builderImpl-->>Client: Return response or error

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Possibly related PRs

• Add retry to Validate #411: Initially introduced the retry logic in the same Validate method, which is now being modified to limit retry attempts.

Suggested reviewers

• laurenleach

Poem

Five tries for the builder, no more,
To validate, then close the door.
Gone are the loops that never end,
Now errors get a chance to mend.
With patience set, and limits clear,
This code hops forward—cheer to cheer! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 686d8db and a9fafc1.

📒 Files selected for processing (1)

• pkg/connectorbuilder/connectorbuilder.go (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📚 Learning: the `connectorbuilder.newconnector` function in the baton-sdk already validates the connector parame...

Learnt from: MarcusGoldschmidt
PR: ConductorOne/baton-sdk#393
File: pkg/test/integration_wrapper.go:54-54
Timestamp: 2025-06-02T21:28:25.367Z
Learning: The `connectorbuilder.NewConnector` function in the baton-sdk already validates the connector parameter using a type switch and returns appropriate errors for nil or invalid connectors in the default case, so additional nil checks are not needed before calling this function.

Applied to files:

• pkg/connectorbuilder/connectorbuilder.go

📚 Learning: the `connectorbuilder.newconnector` function in the baton-sdk already validates the connector parame...

Learnt from: MarcusGoldschmidt
PR: ConductorOne/baton-sdk#393
File: pkg/test/integration_wrapper.go:54-54
Timestamp: 2025-06-02T21:28:25.367Z
Learning: The `connectorbuilder.NewConnector` function in the baton-sdk already validates the connector parameter and returns appropriate errors for nil or invalid connectors, so additional nil checks are not needed before calling this function.

Applied to files:

• pkg/connectorbuilder/connectorbuilder.go

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Cursor Bugbot
• GitHub Check: go-test (1.23.x, ubuntu-latest)
• GitHub Check: go-test (1.23.x, windows-latest)

🔇 Additional comments (1)

pkg/connectorbuilder/connectorbuilder.go (1)

992-992: LGTM! Good defensive programming practice.

Limiting validation retries to 5 attempts prevents potential infinite retry loops and resource exhaustion while still providing reasonable resilience for transient failures. This aligns well with other retry configurations in the codebase that use similar bounded retry patterns.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch mbburch/add-retry-limit-for-validate

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.