Skip to content

Conversation

@loganintech
Copy link
Contributor

No description provided.

@loganintech loganintech requested a review from ggreer September 8, 2025 22:37
@loganintech loganintech marked this pull request as draft September 8, 2025 22:37
@coderabbitai
Copy link

coderabbitai bot commented Sep 8, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch logan/create-streaming-rpc-endpoint-for-entitlement-listing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

}
return err
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Stream Reuse Causes Sync Failures

The entitlementStreamer is reused across multiple resource syncs, which can lead to request/response mismatches on the bidirectional stream. If Send() or Recv() encounters a non-EOF error, the stream isn't reset, leaving it in a broken state for subsequent calls and causing sync failures.

Fix in Cursor Fix in Web

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted, I need to close send on the clients when we exit a sync. In truth, I don't think this is going to end up working at all. We could re-write baton-sdk entirely to be streamified from top to bottom but that's not the world we live in currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants