Skip to content

(WIP) Add id alias #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
MarcusGoldschmidt wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

(WIP) Add id alias #638

MarcusGoldschmidt wants to merge 2 commits into from
+653 −0

Conversation

@MarcusGoldschmidt
Copy link
Contributor

@MarcusGoldschmidt MarcusGoldschmidt commented Jan 15, 2026

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Jan 15, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

ggreer
ggreer reviewed Jan 20, 2026
View reviewed changes
proto/c1/connector/v2/annotation_id_alias.proto

option go_package = "github.com/conductorone/baton-sdk/pb/c1/connector/v2";

message IdAlias {
Copy link
Contributor

@ggreer ggreer Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for a resource, an entitlement, a grant, or all of them? If it's just for one, maybe it can have a name like ResourceAlias and go in annotation_resource.proto.

Also should this have another attribute saying what type of alias it is? eg: ARN, URL, resource id, etc. That attribute could be a string or an enum depending on how you want to use it on the C1 side.

@MarcusGoldschmidt MarcusGoldschmidt changed the title add id alias (WIP) Add id alias Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggreer ggreer ggreer left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MarcusGoldschmidt @ggreer