chore(deps): bump github.com/conductorone/baton-sdk from 0.2.96 to 0.3.31 #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [github.com/conductorone/baton-sdk](https://github.com/conductorone/baton-sdk) from 0.2.96 to 0.3.31. - [Release notes](https://github.com/conductorone/baton-sdk/releases) - [Commits](ConductorOne/baton-sdk@v0.2.96...v0.3.31) --- updated-dependencies: - dependency-name: github.com/conductorone/baton-sdk dependency-version: 0.3.31 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| } | ||
|
|
||
| return status.Error(codes.Unknown, "unsupported content type") | ||
| return status.Error(codes.Unknown, fmt.Sprintf("unsupported content type: %s", resp.Header.Get(ContentType))) |
There was a problem hiding this comment.
Bug: WithGenericResponse Fails with Nil Maps and Unsupported XML
WithGenericResponse has two critical flaws:
- When handling a top-level JSON list, it panics if the
responsemap provided by the caller isnil, as it attempts to write to(*response)["items"]without a nil check. - For XML responses, it incorrectly attempts to
xml.Unmarshalinto amap[string]any(unsupported byencoding/xml), and subsequently inspects an uninitialized local variable, resulting in an "unsupported content type: " error.
These issues render the function unsafe for JSON lists and unusable for XML.
Contributor
Author
|
Superseded by #76. |
dependabot
bot
deleted the
dependabot/go_modules/github.com/conductorone/baton-sdk-0.3.31
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/conductorone/baton-sdk from 0.2.96 to 0.3.31.
Release notes
Sourced from github.com/conductorone/baton-sdk's releases.
... (truncated)
Commits
171428bdont retry ListTicketSchemas forever (#421)5b0fd34Update SDK version to v0.3.30a4fa0d4Limit max attempts for validate (#419)686d8dbUpdate SDK version to v0.3.29ca3aa95Add retries to ListTicketSchemas (#408)465cdb2Update SDK version to v0.3.282a083dfadd log-level debug expires at field (#418)7cedb68Update SDK version to v0.3.27b6d2b49Add WithAlwaysXMLResponse. (#417)86a5fa2Update SDK version to v0.3.26Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)