-
Notifications
You must be signed in to change notification settings - Fork 3
CX-876 Clarify provisioning capabilities for Exchange groups #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated limitations and instructions for Exchange groups provisioning. @mindymo please update if you think it needs more clarification. main change: - Exchange groups provisioning and sync owners is ONLY available using *Client secret* auth method. Using OAuth you are not able to manage exchange groups
📝 WalkthroughWalkthroughDocumentation update to the Microsoft Entra connector clarifying OAuth limitations for Mail Enabled Security and Distribution groups, and updating Exchange group provisioning details to specify client secret authentication and support for provisioning both owners and members. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@baton/microsoft-entra.mdx`:
- Around line 147-149: Update the heading and terminology: change the heading
"Optional: Configure Exchange groups provisioning with **Client secret** based
auth" to use the compound modifier "Client secret-based" and replace the phrase
"mailed security groups" in the same paragraph with the correct term
"mail-enabled security groups" so terminology matches line 24's usage; update
the occurrences around the "Configure Exchange groups provisioning" section and
any related sentences referencing mailed security groups to use "mail‑enabled
security groups".
| ## Optional: Configure Exchange groups provisioning with **Client secret** based auth | ||
|
|
||
| To set up the connector to support provisioning members to Exchange groups, which are distribution lists and mailed security groups, follow these steps: | ||
| To set up the connector to support provisioning owners and members to Exchange groups, which are distribution lists and mailed security groups, follow these steps: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix grammar and terminology issues.
- Line 147: Add hyphen to "secret-based" per compound modifier rules.
- Line 149: "mailed security groups" should be "mail-enabled security groups" to match the terminology used in line 24.
📝 Proposed fix
-## Optional: Configure Exchange groups provisioning with **Client secret** based auth
+## Optional: Configure Exchange groups provisioning with **Client secret**-based auth
-To set up the connector to support provisioning owners and members to Exchange groups, which are distribution lists and mailed security groups, follow these steps:
+To set up the connector to support provisioning owners and members to Exchange groups, which are distribution lists and mail-enabled security groups, follow these steps:📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ## Optional: Configure Exchange groups provisioning with **Client secret** based auth | |
| To set up the connector to support provisioning members to Exchange groups, which are distribution lists and mailed security groups, follow these steps: | |
| To set up the connector to support provisioning owners and members to Exchange groups, which are distribution lists and mailed security groups, follow these steps: | |
| ## Optional: Configure Exchange groups provisioning with **Client secret**-based auth | |
| To set up the connector to support provisioning owners and members to Exchange groups, which are distribution lists and mail-enabled security groups, follow these steps: |
🧰 Tools
🪛 LanguageTool
[grammar] ~147-~147: Use a hyphen to join words.
Context: ...oups provisioning with Client secret based auth To set up the connector to s...
(QB_NEW_EN_HYPHEN)
🤖 Prompt for AI Agents
In `@baton/microsoft-entra.mdx` around lines 147 - 149, Update the heading and
terminology: change the heading "Optional: Configure Exchange groups
provisioning with **Client secret** based auth" to use the compound modifier
"Client secret-based" and replace the phrase "mailed security groups" in the
same paragraph with the correct term "mail-enabled security groups" so
terminology matches line 24's usage; update the occurrences around the
"Configure Exchange groups provisioning" section and any related sentences
referencing mailed security groups to use "mail‑enabled security groups".
|
Looks great, thank you! |
Updated limitations and instructions for Exchange groups provisioning.
@mindymo please update if you think it needs more clarification.
main change:
Summary by CodeRabbit
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.