Skip to content

Some error checking so we don't send unsigned transactions down the wire #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rangelife wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Some error checking so we don't send unsigned transactions down the wire #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions app/hooked-web3-provider.es6
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ var factory = function(Web3) {
}
}

var finishedWithRewrite = () => {
var finishedWithRewrite = (err) => {
if (err) return callback(err);
return super.send(payload, callback);
};

Expand All @@ -35,7 +36,8 @@ var factory = function(Web3) {
// methods to sendRawTransaction, calling out to the transaction_signer to
// get the data for sendRawTransaction.
sendAsync(payload, callback) {
var finishedWithRewrite = () => {
var finishedWithRewrite = (err) => {
if (err) return callback(err);
super.sendAsync(payload, callback);
};

Expand Down