Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a GitHub Actions pipeline to publish the built JavaScript SDK to an S3-backed CDN whenever a new version tag is pushed or manually triggered.
- Introduces a top-level workflow (
publish.yml) to kick off deployments onv*tag pushes and via manual dispatch. - Provides a reusable workflow (
publish-cdn.yml) that checks out code, configures AWS OIDC creds, syncs versioned files to S3, and notifies Slack.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/publish.yml | Defines trigger on tag pushes and manual dispatch; calls the CDN workflow |
| .github/workflows/publish-cdn.yml | Implements checkout, AWS credential setup, file copy/sync to S3, and Slack notification |
Comments suppressed due to low confidence (3)
.github/workflows/publish-cdn.yml:18
- A build step (e.g., installing dependencies and running the build) is missing before copying the
dist/files; without this, thedist/directory may not exist. Consider adding something like:
- name: Install and build
run: |
npm ci
npm run build - uses: actions/checkout@v4
.github/workflows/publish-cdn.yml:1
- [nitpick] The workflow name repeats the word "Publish". Consider simplifying to
name: 'Publish to CDN'for clarity and brevity.
name: 'Publish: Publish to CDN'
.github/workflows/publish.yml:5
- [nitpick] Using
tags: ['v*']matches any tag starting withv. If you intend to deploy only semantic versions, you could use a more precise pattern likev*.*.*to avoid unintended triggers.
tags: ['v*']
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.