[CDX-373] Add FmtOptions to RecommendationsRequest#96
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds FmtOptions support to RecommendationsRequest, enabling control over result formatting in recommendations API calls (e.g., returning hidden fields and facets). This aligns with existing support for FmtOptions in other request types like SearchRequest, BrowseRequest, and AutocompleteRequest.
Changes:
- Added FmtOptions property to RecommendationsRequest class
- Integrated FmtOptions parameters into GetRequestParameters() method
- Added two integration tests to verify FmtOptions usage with hidden fields and hidden facets
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/constructor.io/models/Recommendations/RecommendationsRequest.cs | Added FmtOptions property and integrated it into GetRequestParameters() method following the established pattern |
| src/Constructorio_NET.Tests/client/modules/RecommendationsTests.cs | Added integration tests for FmtOptions with HiddenFields and HiddenFacets |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/Constructorio_NET.Tests/client/modules/RecommendationsTests.cs
Outdated
Show resolved
Hide resolved
src/Constructorio_NET.Tests/client/modules/RecommendationsTests.cs
Outdated
Show resolved
Hide resolved
src/Constructorio_NET.Tests/client/modules/RecommendationsTests.cs
Outdated
Show resolved
Hide resolved
Mudaafi
left a comment
Mudaafi
left a comment
There was a problem hiding this comment.
Looks like some of the tests aren't checking the correct fields
…s.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Mudaafi
left a comment
Mudaafi
left a comment
There was a problem hiding this comment.
thanks for making the changes
esezen
merged commit d1d7330
into
cdx-373-netcore-update-fmtoptions
* Properly type FmtOptions * Update src/constructor.io/utils/Helpers.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update FmtOptions * Add tests * Address comments * Address comments * Refactor FmtOptions completley * Remove legacy fields * [CDX-373] Add FmtOptions to RecommendationsRequest (#96) * Add rex support * Update src/Constructorio_NET.Tests/client/modules/RecommendationsTests.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update tests * Fix flaky test --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Address comments * Remove unused constructor * Address commenst * Update test to use a different pod --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.