Skip to content

[CDX-348] Apply the OS UI docs guideline for Storybook#254

Merged
Alexey-Pavlov merged 10 commits intomainfrom
cdx-348-os-ui-docs-autocomplete-ui-apply-the-os-ui-docs-guideline
Feb 20, 2026
Merged

[CDX-348] Apply the OS UI docs guideline for Storybook#254
Alexey-Pavlov merged 10 commits intomainfrom
cdx-348-os-ui-docs-autocomplete-ui-apply-the-os-ui-docs-guideline

Conversation

@Alexey-Pavlov
Copy link
Contributor

This pull request makes significant updates to the Storybook configuration, primarily to improve documentation handling, enhance the organization and navigation of stories, and clean up unused or redundant story files.

OS UI Libraries Documentation Guideline

This comment was marked as outdated.

…tocomplete-ui-apply-the-os-ui-docs-guideline

# Conflicts:
#	package-lock.json
#	src/utils/shopifyDefaults.ts
@constructor-claude-bedrock

This comment has been minimized.

Copy link
Contributor

@esezen esezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. I left some comments. Can we also update the main link in README.md?

@@ -1,581 +0,0 @@
import { within, userEvent, expect, fn } from '@storybook/test';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we removing the tests completely?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope! I did that by mistake 👀

@@ -1,463 +0,0 @@
import { within, userEvent, expect, fn, waitFor } from '@storybook/test';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

Co-authored-by: Enes Kutay SEZEN <eneskutaysezen@gmail.com>
@constructor-claude-bedrock

This comment has been minimized.

…ui-apply-the-os-ui-docs-guideline' into cdx-348-os-ui-docs-autocomplete-ui-apply-the-os-ui-docs-guideline
@constructor-claude-bedrock

This comment has been minimized.

@constructor-claude-bedrock

This comment has been minimized.

@Alexey-Pavlov Alexey-Pavlov requested a review from esezen February 12, 2026 18:07
@constructor-claude-bedrock
Copy link

Code Review Results

✅ Strengths

Well-organized documentation restructure following OS UI guidelines with clear navigation hierarchy and comprehensive MDX documentation for all components and hooks.

🚨 Critical Issues

None identified.

⚠️ Important Issues

[File: .storybook/main.js Line: L1]

  • Issue: Using ES6 import syntax with export default in .storybook/main.js, but the file extension is .js not .mjs. This requires the package to have "type": "module" in package.json or the file to be renamed to .mjs.
  • Why: Without proper module configuration, Node.js will fail to parse ES6 module syntax in .js files.
  • Recommendation: Either rename .storybook/main.js to .storybook/main.mjs, or verify that Storybook's build system handles this transformation correctly. If Storybook 8.6+ handles this automatically, this is acceptable, but should be tested.

[File: .eslintrc.json Line: L106]

  • Issue: Adding "**/*.mdx" to eslintignore patterns is good, but the PR removes old story files without confirming they're no longer needed in production builds.
  • Why: The .storybook/main.js previously had production/development branching logic that filtered stories, which has been removed.
  • Recommendation: Confirm that removing the isProduction conditional and all old story paths won't break production Storybook builds.

[File: package.json Line: L110]

  • Issue: Added remark-gfm as a devDependency for GitHub Flavored Markdown support, and package-lock.json was properly updated.
  • Why: This is correct - the dependency addition matches the package-lock.json changes.
  • Recommendation: No action needed - this is properly implemented.

💡 Suggestions

[File: .storybook/preview.jsx Line: L35-L38]

  • Suggestion: The new table of contents (TOC) configuration is a nice addition. Consider documenting this feature in the Storybook setup documentation if it's a new pattern for the team.

[File: src/stories/components/CioAutocomplete/CioAutocomplete.mdx]

  • Suggestion: The documentation is comprehensive and well-structured. Consider adding a troubleshooting section for common issues users might encounter (e.g., API key errors, CORS issues, etc.).

[General]

  • Suggestion: The PR removes 10 old story files and adds many new MDX documentation files. Consider adding a migration guide or changelog entry to help team members understand the new structure.

[File: .storybook/main.js Line: L4-L11]

  • Suggestion: The explicit story ordering is excellent for documentation discoverability. The order follows a logical learning path: Getting Started → Basic Concepts → Components → Hooks → Utils.

[File: README.md Line: L12, L48]

  • Suggestion: Updated Storybook URLs to point to the new "Getting Started/Introduction" path. Verify these links work after deployment.

Overall Assessment: ✅ Pass


Summary

This is a well-executed documentation restructuring that follows the OS UI Libraries Documentation Guideline. The changes improve organization and discoverability. The main concern is ensuring the ES6 module syntax in .storybook/main.js is compatible with the build system, and verifying that removing the production/development story filtering doesn't break production builds. No test coverage is required for documentation changes, which is appropriate for this type of refactoring.

Copy link
Contributor

@esezen esezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alexey-Pavlov Alexey-Pavlov merged commit ad98280 into main Feb 20, 2026
11 checks passed
@Alexey-Pavlov Alexey-Pavlov deleted the cdx-348-os-ui-docs-autocomplete-ui-apply-the-os-ui-docs-guideline branch February 20, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants