Skip to content

fix(zec): fix zec build error#1105

Merged
hankliu418 merged 5 commits intohotfix-publish-issuefrom
publish_trigger
Feb 5, 2026
Merged

fix(zec): fix zec build error#1105
hankliu418 merged 5 commits intohotfix-publish-issuefrom
publish_trigger

Conversation

@hankliu418
Copy link
Contributor

@hankliu418 hankliu418 commented Feb 5, 2026


Checklist:

  • README.md includes:
    • The details of signing data and transaction data, this includes parameters.
    • Official docs or white paper.
    • Website or api can query assets and broadcast transaction.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

PR Summary by Typo

Overview

This PR addresses a build error within the Zcash (ZEC) coin package by updating dependencies and refining TypeScript configuration.

Key Changes

  • Corrected the NPM_404_ERR_CODE string literal in publishing action utilities.
  • Updated development dependencies in packages/coin-zec, including @types/bs58check, typescript, and @types/node.
  • Modified packages/coin-zec/tsconfig.json to include dom and esnext.disposable libraries, explicitly set node types, and added skipLibCheck: true to resolve potential type conflicts.

Work Breakdown

Category Lines Changed
New Work 32 (74.4%)
Rework 11 (25.6%)
Total Changes 43
To turn off PR summary, please visit Notification settings.

@typo-app
Copy link

typo-app bot commented Feb 5, 2026

Static Code Review 📊

✅ All quality checks passed!

@cbx-tech cbx-tech requested review from a team, Dorac, Rickuan, a0979470582, gundomlegend, jin860315, melody0000tw and tp26610 and removed request for a team February 5, 2026 17:24
@hankliu418 hankliu418 merged commit b09ee78 into hotfix-publish-issue Feb 5, 2026
1 of 3 checks passed
@hankliu418 hankliu418 deleted the publish_trigger branch February 5, 2026 17:25
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2026

Copy link

@typo-app typo-app bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Code Review 🤖

Files Reviewed: 5
Comments Added: 0
Lines of Code Analyzed: 54
Critical Issues: 0

PR Health: Excellent 🔥

Give 👍 or 👎 on each review comment to help us improve.

hankliu418 added a commit that referenced this pull request Feb 6, 2026
* update publish action

* fix - publish issue (#1103)

* add console log

* update console content

---------

Co-authored-by: Hank Liu <hankliu@coolbitx.com>

* Publish trigger (#1104)

* add console log

* update console content

* update err code adjudgement

---------

Co-authored-by: Hank Liu <hankliu@coolbitx.com>

* fix(zec): fix zec build error (#1105)

* add console log

* update console content

* update err code adjudgement

* fix build issue

* remove debug log in publish action

---------

Co-authored-by: Hank Liu <hankliu@coolbitx.com>

* remove redundant import and log

---------

Co-authored-by: Hank Liu <hankliu@coolbitx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant