Skip to content

fix(zec): Hotfix publish issue#1107

Merged
hankliu418 merged 5 commits intomasterfrom
hotfix-publish-issue
Feb 6, 2026
Merged

fix(zec): Hotfix publish issue#1107
hankliu418 merged 5 commits intomasterfrom
hotfix-publish-issue

Conversation

@hankliu418
Copy link
Contributor

@hankliu418 hankliu418 commented Feb 5, 2026


Checklist:

  • README.md includes:
    • The details of signing data and transaction data, this includes parameters.
    • Official docs or white paper.
    • Website or api can query assets and broadcast transaction.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

PR Summary by Typo

Overview

This PR provides a hotfix for a Zcash publishing issue by improving error handling in the publish action, correcting an NPM error code, and updating development dependencies and TypeScript configuration for the ZEC coin package.

Key Changes

  • Corrected the NPM_404_ERR_CODE string to accurately match NPM error messages.
  • Enhanced error message extraction and reporting within the command utility to provide more informative failure reasons during publishing.
  • Updated development dependencies in packages/coin-zec, including @types/bs58check, typescript, and @types/node.
  • Modified packages/coin-zec/tsconfig.json to include lib, types, and skipLibCheck for improved type checking and conflict resolution.
  • Improved logging for package names in the isLocalUpgraded function.

Work Breakdown

Category Lines Changed
New Work 40 (66.7%)
Churn 1 (1.7%)
Rework 19 (31.7%)
Total Changes 60
To turn off PR summary, please visit Notification settings.

Hank Liu and others added 5 commits February 5, 2026 20:29
* add console log

* update console content

---------

Co-authored-by: Hank Liu <hankliu@coolbitx.com>
* add console log

* update console content

* update err code adjudgement

---------

Co-authored-by: Hank Liu <hankliu@coolbitx.com>
* add console log

* update console content

* update err code adjudgement

* fix build issue

* remove debug log in publish action

---------

Co-authored-by: Hank Liu <hankliu@coolbitx.com>
@typo-app
Copy link

typo-app bot commented Feb 5, 2026

Static Code Review 📊

✅ All quality checks passed!

@cbx-tech cbx-tech requested review from a team, Dorac, Rickuan, a0979470582, gundomlegend, jin860315, melody0000tw and tp26610 and removed request for a team February 5, 2026 17:39
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2026

Copy link

@typo-app typo-app bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Code Review 🤖

Files Reviewed: 5
Comments Added: 0
Lines of Code Analyzed: 79
Critical Issues: 0

PR Health: Excellent 🔥

Give 👍 or 👎 on each review comment to help us improve.

@hankliu418 hankliu418 merged commit 06da809 into master Feb 6, 2026
7 checks passed
@hankliu418 hankliu418 deleted the hotfix-publish-issue branch February 6, 2026 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants