fix(ZEC): update ANYONECANPAY sign parameter#1109
Merged
hankliu418 merged 2 commits intomasterfrom Feb 25, 2026
Merged
Conversation
|
Static Code Review 📊 ✅ All quality checks passed! |
gundomlegend
previously approved these changes
Feb 25, 2026
melody0000tw
previously approved these changes
Feb 25, 2026
Contributor
|
可以修一下測試,更新簽章結果 |
c3c435b
melody0000tw
approved these changes
Feb 25, 2026
gundomlegend
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
PR Summary by Typo
Overview
This PR addresses a fix for Zcash (ZEC) transaction signing, specifically when using the
ANYONECANPAYflag, by adjusting how transaction parameters are handled during the signing process.Key Changes
@coolwallet/zecto2.0.1-beta.0.inputsparameter fromsignTransaction,getArgument, andgetScriptSigningActionsfunctions insign.tsandscriptUtil.ts.scriptUtil.tsto sethashPrevoutsandhashSequenceto zero-filled buffers, aligning withANYONECANPAYsigning requirements.index.spec.tsto reflect the corrected signed transaction output.Work Breakdown
To turn off PR summary, please visit Notification settings.