Open
Conversation
Few basic information for contributing to a repository.
Author
|
@AasthaGitHub ma'am and @akrishna0 sir I request you to please review my work |
AasthaMehtaTech
requested changes
Oct 28, 2020
Contributor
AasthaMehtaTech
left a comment
There was a problem hiding this comment.
Hello @Sejal1Verma, greetings for your first contribution here.
Contributing guidelines would be more beginner friendly when we include the exact commands which one needs to follow. So, kindly make the following changes:
- Describe exact steps (with commands - for different systems: Windows, Mac, Linux)
- It'd be great if u could attach actual pictures of example how you made this PR.
- In PR description remove the unnecessary details & point a reference to the prevailing documentation issue.
- U might want to add the rules of maintaining the decorum/coding style while one wants to contribute.
Member
|
Please follow the template don't just make a pull request after making changes describe everything as asked in the PR template if possible |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Few basic information for contributing to a repository.
Pull request type
Please check the type of change your PR introduces:
Related issue
Proposed changes
Additional Information
Checklists
Screenshots