Skip to content

fix: resolve broken image opening (lightbox + attachment filtering) #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
idofrizler merged 2 commits into from
Feb 27, 2026
Merged

fix: resolve broken image opening (lightbox + attachment filtering) #483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b31bcc
chore(build): add node-pty to asarUnpack for electron packaging
Feb 27, 2026
9790e8e
fix: open lightbox on image click and filter canonical messages for a…
Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
"asarUnpack": [
"node_modules/@github/copilot-*/**/*",
"node_modules/ffmpeg-static/**/*",
"node_modules/node-pty/**/*",
"public/whisper-cpp/**/*",
"public/whisper-model/**/*"
],
Expand Down
10 changes: 6 additions & 4 deletions src/renderer/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -969,7 +969,10 @@ const App: React.FC = () => {
// Save message attachments whenever tabs/messages change
useEffect(() => {
tabs.forEach((tab) => {
const attachments = tab.messages
const canonicalMessages = tab.messages.filter(
(msg) => msg.role === 'user' || msg.role === 'assistant'
);
const attachments = canonicalMessages
.map((msg, index) => ({
messageIndex: index,
imageAttachments: msg.imageAttachments,
Expand Down Expand Up @@ -2974,10 +2977,9 @@ Only when ALL the above are verified complete, output exactly: ${RALPH_COMPLETIO
[commitModal]
);

// Handle image click (for now, just a no-op - can be extended for image viewer modal)
// Handle image click
const handleImageClick = useCallback((src: string, alt: string) => {
// Placeholder for future image viewer modal
console.log('Image clicked:', src, alt);
setLightboxImage({ src, alt });
}, []);

// Handle confirmation from shrink modal
Expand Down