Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/main/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ import {
extractFilesToDelete,
} from './utils/extractExecutables';
import { createPermissionRequestId } from './utils/permissionRequest';
import { isToolStallHeartbeatEventType } from './utils/toolStallHeartbeat';
import {
validateCopilotCreateSessionArgs,
validateCopilotResumePreviousSessionArgs,
Expand Down Expand Up @@ -864,6 +865,10 @@ function registerSessionEventForwarding(sessionId: string, session: CopilotSessi
toolName: event.data.toolName,
input: event.data.arguments || (event.data as Record<string, unknown>),
});
} else if (isToolStallHeartbeatEventType(event.type)) {
// SDK emits periodic progress/partial-result events while a tool is still active.
// Treat these as heartbeat signals so long-running tools don't trip the stall timeout.
refreshToolStallTimer(sessionId);
} else if (event.type === 'tool.execution_complete') {
log.debug(`[${sessionId}] Tool end: ${event.data.toolCallId}`);
clearToolStallTimer(sessionId);
Expand Down Expand Up @@ -1009,11 +1014,14 @@ function stopKeepAlive(): void {
// Tool execution stall detection - auto-abort sessions with hung tool calls
const TOOL_STALL_TIMEOUT_MS = 5 * 60 * 1000; // 5 minutes
const sessionToolStallTimers = new Map<string, NodeJS.Timeout>();
const sessionActiveToolNames = new Map<string, string>();

function startToolStallTimer(sessionId: string, toolName: string): void {
clearToolStallTimer(sessionId);
sessionActiveToolNames.set(sessionId, toolName);
const timer = setTimeout(async () => {
sessionToolStallTimers.delete(sessionId);
sessionActiveToolNames.delete(sessionId);
const sessionState = sessions.get(sessionId);
if (!sessionState) return;
log.warn(
Expand Down Expand Up @@ -1044,12 +1052,19 @@ function startToolStallTimer(sessionId: string, toolName: string): void {
sessionToolStallTimers.set(sessionId, timer);
}

function refreshToolStallTimer(sessionId: string): void {
const activeToolName = sessionActiveToolNames.get(sessionId);
if (!activeToolName) return;
startToolStallTimer(sessionId, activeToolName);
}

function clearToolStallTimer(sessionId: string): void {
const timer = sessionToolStallTimers.get(sessionId);
if (timer) {
clearTimeout(timer);
sessionToolStallTimers.delete(sessionId);
}
sessionActiveToolNames.delete(sessionId);
}

// Resume a session that has been disconnected
Expand Down Expand Up @@ -1258,6 +1273,8 @@ async function startEarlySessionResumption(): Promise<void> {
toolName: event.data.toolName,
input: event.data.arguments || (event.data as Record<string, unknown>),
});
} else if (isToolStallHeartbeatEventType(event.type)) {
refreshToolStallTimer(sessionId);
} else if (event.type === 'tool.execution_complete') {
log.debug(`[${sessionId}] Tool end: ${event.data.toolCallId}`);
clearToolStallTimer(sessionId);
Expand Down Expand Up @@ -2435,6 +2452,8 @@ async function initCopilot(): Promise<void> {
toolName: event.data.toolName,
input: event.data.arguments || (event.data as Record<string, unknown>),
});
} else if (isToolStallHeartbeatEventType(event.type)) {
refreshToolStallTimer(sessionId);
} else if (event.type === 'tool.execution_complete') {
log.debug(`[${sessionId}] Tool end: ${event.data.toolCallId}`);
clearToolStallTimer(sessionId);
Expand Down Expand Up @@ -5054,6 +5073,8 @@ ipcMain.handle(
toolName: event.data.toolName,
input: event.data.arguments || (event.data as Record<string, unknown>),
});
} else if (isToolStallHeartbeatEventType(event.type)) {
refreshToolStallTimer(sessionId);
} else if (event.type === 'tool.execution_complete') {
log.debug(`[${sessionId}] Tool end: ${event.data.toolCallId}`);
clearToolStallTimer(sessionId);
Expand Down
15 changes: 15 additions & 0 deletions src/main/utils/toolStallHeartbeat.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import { describe, expect, it } from 'vitest';
import { isToolStallHeartbeatEventType } from './toolStallHeartbeat';

describe('isToolStallHeartbeatEventType', () => {
it('treats periodic tool activity events as heartbeats', () => {
expect(isToolStallHeartbeatEventType('tool.execution_progress')).toBe(true);
expect(isToolStallHeartbeatEventType('tool.execution_partial_result')).toBe(true);
});

it('does not treat start/complete events as heartbeats', () => {
expect(isToolStallHeartbeatEventType('tool.execution_start')).toBe(false);
expect(isToolStallHeartbeatEventType('tool.execution_complete')).toBe(false);
expect(isToolStallHeartbeatEventType('session.idle')).toBe(false);
});
});
3 changes: 3 additions & 0 deletions src/main/utils/toolStallHeartbeat.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export function isToolStallHeartbeatEventType(eventType: string): boolean {
return eventType === 'tool.execution_progress' || eventType === 'tool.execution_partial_result';
}