Add support for Dark / Light theme with low transparency fallback#52
Open
NSMustache wants to merge 2 commits intoCooperRS:masterfrom
Open
Add support for Dark / Light theme with low transparency fallback#52NSMustache wants to merge 2 commits intoCooperRS:masterfrom
NSMustache wants to merge 2 commits intoCooperRS:masterfrom
Conversation
CooperRS
reviewed
Apr 17, 2020
Owner
CooperRS
left a comment
CooperRS
left a comment
There was a problem hiding this comment.
Thank you for the contribution! 👏
In general, the PR seems fine to me 👍. I only have a question about one change that seems a bit unrelated 🤔
| //Debugging Accessibility Labels | ||
| #ifdef DEBUG | ||
| self.topContainer.accessibilityLabel = @"TopContainer"; | ||
| self.topContainer.accessibilityLabel = @"TopContainer "; |
Author
There was a problem hiding this comment.
Apologies, I just pushed commit acbec02 to fix this typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the use of
[UIColor whiteColor]as a container background when transparency / blur is disabled with the system-defined[UIColor secondaryBackgroundColor]on iOS 13+ as this color is impacted by dark/light mode.