Merged
Conversation
jungmyunggi
reviewed
Dec 27, 2024
Comment on lines
+17
to
+24
| const dfs = (tree, curr) => { | ||
| if (tree.left) dfs(tree.left, curr + tree.left.val); | ||
| if (tree.right) dfs(tree.right, curr + tree.right.val); | ||
| if (!tree.left && !tree.right && curr === targetSum) { | ||
| answer = true; | ||
| return; | ||
| } | ||
| }; |
Collaborator
There was a problem hiding this comment.
재귀는 탈출조건을 가장 상단에 적는다고 알고있는데 아래에 배치하셨네요 이러면 리프노드에서 한단계 더 밑으로 내려가서 검사를 진행한 이후에 진행이 될거같은데 맞나요?
Member
Author
There was a problem hiding this comment.
- 자식이 있다. -> 메서드 호출
- 자식이 없다. ->
targetSum과 비교
dfs 함수가 결국 위 두가지로 나뉘기 때문에, 재귀 함수 내부의 배치 순서가 크게 중요하지 않다고 생각했던 것 같습니다.
근데 생각해보니까 함수의 최하단에 배치되어 있어 탈출을하는 경우에도 결국 모든 라인을 해석한 후 탈출하게 되겠네요. 짚어주셔서 감사합니다 ㅎㅎ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
문제
Constraints
[0, 5000].-1000 <= Node.val <= 1000-1000 <= targetSum <= 1000Edge Case
root = [1, 2], targetSum = 0트리를 탐색할 때 시작 값을 0으로 하게 되면 위 반례가 생기므로 반드시 루트 노드의 값을 시작으로 탐색을 진행하여야 합니다.
풀이
2-1. 동일하다면 true를 반환한다.
어려웠던 점
알게된 점