CKE-92 catalog and workspace protocol#238
Merged
jens-meisner merged 16 commits intomainfrom Nov 11, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the monorepo to use pnpm's catalog and workspace protocols for dependency management. The catalog feature centralizes version definitions in pnpm-workspace.yaml, while the workspace protocol enables proper resolution of internal packages.
Key changes:
- Introduced a catalog section in
pnpm-workspace.yamldefining versions for all external dependencies - Replaced explicit version numbers with
catalog:references for external dependencies across all package.json files - Replaced version-pinned internal dependencies with
workspace:*protocol for proper monorepo package resolution - Converted CommonJS module syntax to ES modules in Jest configuration files
Reviewed Changes
Copilot reviewed 31 out of 32 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Added catalog section defining centralized versions for all external dependencies |
| packages/*/package.json (25 files) | Updated to use catalog protocol for external dependencies and workspace protocol for internal dependencies |
| package.json | Migrated root package dependencies to use catalog protocol |
| app/package.json | Migrated application dependencies to use catalog protocol |
| itest/package.json | Migrated integration test dependencies to use catalog protocol |
| itest/jest*.js (3 files) | Converted from CommonJS to ES modules (require → import, module.exports → export default) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/ckeditor5-coremedia-studio-integration-mock/package.json
Outdated
Show resolved
Hide resolved
…ith catalog protocol
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 34 out of 35 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.