fix(tui): enable paste in MCP server configuration modal#276
Merged
Conversation
Previously, when adding an MCP server (HTTP or stdio) or setting API keys, users could not paste text into the input fields. This was because the paste event (EngineEvent::Paste) was only routed to Form modals and the main input widget, not to the unified modal stack that includes the MCP manager modal. Changes: - Add handle_paste method to the Modal trait with default no-op impl - Add handle_paste method to ModalStack to delegate to top modal - Implement handle_paste in McpManagerModal for all text input modes: - AddStdioServer (name, command, args fields) - AddHttpServer (name, url fields) - SetAuth (api_key field) - SelectFromRegistry (search_query field) - Update event loop to check modal_stack for paste events first
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When adding an MCP server (HTTP or stdio) or setting API keys in the TUI, users could not paste text into the input fields (name, URL, API key, etc.). The paste operation simply didn't work.
Root Cause
The paste event (
EngineEvent::Paste) was only routed to:ActiveModal::Form)However, the MCP manager modal uses the unified modal stack system (
ModalStack) with theModaltrait, which did not have ahandle_pastemethod.Solution
handle_pastemethod to theModaltrait with a default no-op implementationhandle_pastemethod toModalStackto delegate to the top modalhandle_pasteinMcpManagerModalfor all text input modes:AddStdioServer: name, command, args fieldsAddHttpServer: name, url fieldsSetAuth: api_key fieldSelectFromRegistry: search_query fieldmodal_stackfor paste events firstTesting
cargo check -p cortex-tuipassescargo fmt --checkpasses