fix(tui): display error message when subagent crashes#295
Merged
Conversation
Previously when a subagent task crashed or failed, it was immediately removed from the UI without displaying what error occurred. This made debugging very difficult as users could see the task disappear but had no information about what went wrong. Changes: - Add error_message field to SubagentTaskDisplay to store the error - Update ToolEvent::Failed handler to set the error message and keep the failed subagent visible instead of immediately removing it - Update render_subagent to display the error message in red when status is Failed - Failed subagents are still cleaned up on the next conversation turn via clear_tool_calls which retains only non-terminal subagents
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously when a subagent task crashed or failed, it was immediately removed from the UI without displaying what error occurred. This made debugging very difficult as users could see the task disappear but had no information about what went wrong.
Changes
error_messagefield toSubagentTaskDisplayto store the errorToolEvent::Failedhandler to set the error message and keep the failed subagent visible instead of immediately removing itrender_subagentto display the error message in red when status is Failedclear_tool_callswhich retains only non-terminal subagentsTesting