fix(tui): rate limit frame capture to max 1 frame per second#297
Merged
fix(tui): rate limit frame capture to max 1 frame per second#297
Conversation
When CORTEX_TUI_CAPTURE_ALL is enabled, frames were being captured on every render, which is excessive and generates too many debug logs. This change adds rate limiting so that in capture_all mode, frames are only captured at most once per second. This significantly reduces log noise and storage overhead while still providing useful debugging information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
CORTEX_TUI_CAPTURE_ALLis enabled, frames were being captured on every render, which is excessive and generates too many debug logs (e.g., frame 10172, 10173, 10174... all within the same second).Changes
capture_allmode is enabled, frames are now captured at most once per secondlast_capture_timefield to track when the last frame was capturedstd::time::Instantfor precise timingImpact