fix(cli): parse flags correctly when mixed with positional args#7
Closed
fix(cli): parse flags correctly when mixed with positional args#7
Conversation
Fixes bounty issue #1523
The 'message' argument was configured with trailing_var_arg=true, which caused all subsequent flags to be treated as part of the message string. This prevented valid flags like --continue or --session from working when specified after the message. By removing this attribute, flags are now correctly parsed regardless of their position relative to the message argument.
Also fixed a compilation error in cortex-engine/src/tasks/snapshot.rs where 'permissions' variable was ignored in pattern match but used in conditional compilation block.
Contributor
Author
|
Closing as this feature has already been implemented in a batch commit (see commit history). The changes are merged into master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
cortex runcommand was failing to correctly parse flags like--continueor--sessionwhen they appeared after the message argument. This was because themessageargument was configured to capture all trailing variable arguments.Changes
#[arg(trailing_var_arg = true)]from themessagefield inRunClistruct.cortex-engine/src/tasks/snapshot.rs(unused variablepermissions).Testing
cargo check -p cortex-cliandcargo check -p cortex-engine.Related
Fixes PlatformNetwork/bounty-challenge#1523