Feature/user type selections screen#42
Conversation
|
| <string name="skip">تخطى</string> | ||
|
|
||
| <!-- Account Setup UserTypeSelectionScreen --> | ||
| <string name="how_would_you_like_to_use_san3a">كيف ترغب في استخدام صُنع؟</string> |
There was a problem hiding this comment.
اين الهوية؟ اين كرافتو؟
| <string name="account_setup_craftsman_category_description">Choose your specialties to get relevant job requests. You can change this later.</string> | ||
|
|
||
| <!-- Account Setup UserTypeSelectionScreen --> | ||
| <string name="how_would_you_like_to_use_san3a">How would you like to use San3a?</string> |
There was a problem hiding this comment.
same here regarding the name
| .fillMaxSize() | ||
| .windowInsetsPadding(WindowInsets.safeDrawing) | ||
| .background(AppTheme.craftoColors.background.screen) | ||
| .padding(horizontal = 16.dp, vertical = 16.dp), |
There was a problem hiding this comment.
you can give only one value for the padding as it is the same
| ) { | ||
| ProgressIndicator( | ||
| currentPage = 1, | ||
| totalPage = 4, |
There was a problem hiding this comment.
why we have hard values? we should pass them
| .fillMaxWidth(0.75f) | ||
| ) | ||
| Column( | ||
| modifier = Modifier.weight(1f), |
There was a problem hiding this comment.
we can use one col for simplicity
| img = painterResource(Res.drawable.customer), | ||
| title = stringResource(Res.string.customer), | ||
| caption = stringResource(Res.string.i_need_help_with_a_service), | ||
| isSelected = selectedRole == "Customer", |
There was a problem hiding this comment.
plz avoid hard coded strings
| img = painterResource(Res.drawable.carftsman), | ||
| title = stringResource(Res.string.craftsman), | ||
| caption = stringResource(Res.string.i_offer_services), | ||
| isSelected = selectedRole == "Craftsman", |
There was a problem hiding this comment.
same here regarding the hard code strings
|
|
||
| PrimaryButton( | ||
| text = stringResource(Res.string.next), | ||
| enabled = true, |
There was a problem hiding this comment.
if there is no default selection, we need to keep the button disabled until the user choose a card
3 participants
Uh oh!
There was an error while loading. Please reload this page.