Merged
Conversation
One less thing to have to fix with Rails upgrades, and gem has not needed changes for the past few upgrades anyway.
There was a problem hiding this comment.
Pull Request Overview
This PR loosens the Rails version requirements by removing upper version constraints to allow compatibility with newer Rails versions. The changes enable the gem to work with Rails 7.1+ while maintaining backward compatibility with older versions.
- Removed upper version bounds (
< 7.1) from Rails-related dependencies - Pinned bundler version in Docker entrypoint to ensure consistent behavior
- Added specific Rails 7.0 versions to Gemfile for testing purposes
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| csv2db.gemspec | Removed upper version constraints for activerecord, activesupport, and railties dependencies |
| docker-entrypoint.sh | Pinned bundler version to 2.4.22 for consistent dependency resolution |
| Gemfile | Added Rails 7.0 gems for testing compatibility with newer Rails versions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
rjpaskin
force-pushed
the
loosen-rails-version-requirement
branch
from
c83b30a to
e7041f1
Compare
Contributor
Author
|
Force-pushed in order to kick off a CodeQL analysis |
reissjohnson
approved these changes
Oct 20, 2025
sanketp85
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.