Merged
Conversation
One less thing to have to fix with Rails upgrades, and gem has not needed changes for the past few upgrades anyway.
There was a problem hiding this comment.
Pull Request Overview
This PR removes the upper version constraint (< 7.1) from Rails-related dependencies, allowing the gem to work with Rails 7.1 and later versions. The changes enable compatibility testing with Rails 7.0 while maintaining backward compatibility with Rails 4.2+.
Key Changes:
- Removed upper version limits on
activerecord,activesupport, andrailtiesdependencies - Pinned bundler version in Docker entrypoint script
- Added Rails 7.0 dependencies to Gemfile for testing purposes
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| report_generator.gemspec | Removed < 7.1 version constraints from Rails dependencies to allow newer versions |
| docker-entrypoint.sh | Pinned bundler to version 2.4.22 for consistent builds |
| Gemfile | Added Rails 7.0 gems for testing compatibility with the loosened version requirements |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
reissjohnson
approved these changes
Oct 20, 2025
sanketp85
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.