change minimum timeout to 0.5 seconds#25
Open
ewalke31 wants to merge 1 commit intoCrimsonVista:masterfrom
Open
change minimum timeout to 0.5 seconds#25ewalke31 wants to merge 1 commit intoCrimsonVista:masterfrom
ewalke31 wants to merge 1 commit intoCrimsonVista:masterfrom
Conversation
The loop call_later() function returns a timeout message for times >= 1 second, so changing the minimum timeout to 0.5 allows this to be avoided.
sethnielson
requested review from
HarleyCody,
emengbenben,
fath0218,
heaventourist,
lol-fi and
vaikunthsd
Contributor
|
call_later can be used with decimal timeout. |
heaventourist
approved these changes
Apr 3, 2019
Contributor
So what are you saying...????? It messes up the timeout is greater than 1 second so we want it to have a decimal timeout........but right now we aren't allowed to go less than five seconds....which is more than one second |
HarleyCody
approved these changes
Apr 10, 2019
emengbenben
approved these changes
Apr 10, 2019
heaventourist
approved these changes
Apr 10, 2019
vaikunthsd
approved these changes
Apr 10, 2019
vaikunthsd
left a comment
vaikunthsd
left a comment
There was a problem hiding this comment.
Approved. Please resolve the conflicts before merging the changes into main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The loop call_later() function returns a timeout message for times >= 1 second, so changing the minimum timeout to 0.5 allows this to be avoided.