updates to support installing automactc script via pip#2
Open
ryandeivert wants to merge 2 commits intoCrowdStrike:masterfrom
Open
updates to support installing automactc script via pip#2ryandeivert wants to merge 2 commits intoCrowdStrike:masterfrom
ryandeivert wants to merge 2 commits intoCrowdStrike:masterfrom
Conversation
updates to be installable via pip
Author
|
@kshitijkumar14 any chance I could get some feedback on this? |
Contributor
|
Hi @ryandeivert - thanks a ton for these updates. I'll be reviewing these and will follow up with you. |
Author
|
thanks @kshitijkumar14 :) friendly ping again to keep this alive. any updates? |
Author
|
hello @kshitijkumar14 .. just curious if this is still on your radar. I think a lot of people would benefit from this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to @kshitijkumar14
We are interested in leveraging some of the functionality of automactc, but cannot do so in its current form. Ideally, this would be installable via pip to support on-demand installation (when applicable). These changes are largely to support that.
I'm happy to answer any questions about the change or update as you see fit. With these changes, you will be able to publish to pypi.
Changes
ModuleRegistryfor storing and accessing module classes.__main__imports from modules.CLIRunnerclass to help organize things and store variables.automactcfolder to better support packaging.setup.py) to allow for installing via pip. This will result in aautomactcexecutable being installed.setup.pyfor now - this can be updated as desired prior to publishing to pypi.