Allow pass through of certain args #9
Conversation
jnmandal
force-pushed
the
sinsemilla
branch
4 times, most recently
from
a2a51b1 to
41730af
Compare
| {:chaps, ">= 0.15.0", only: :test, optional: true}, | ||
| {:credo, ">= 0.0.0", only: :test, runtime: false, optional: true} | ||
| {:chaps, ">= 1.0.0", only: :test, optional: true}, | ||
| {:credo, ">= 1.7.0", only: :test, runtime: false, optional: true} |
There was a problem hiding this comment.
These are the most recent. I'm not clear if this could be really painful in consumer applications... If so, may need to lower these to more reasonable versions? I didn't notice any problems in agora, which I tested against this.
| @@ -1,2 +1,2 @@ | |||
| elixir 1.10.3-otp-21 | |||
| erlang 21.0 | |||
| elixir 1.14.0-otp-25 | |||
There was a problem hiding this comment.
hm...not sure if older apps that use bless all can safely use elixir 1.14 🤔 could it not have stayed on 1.10 for these changes?
There was a problem hiding this comment.
I assumed 1.10 was way out of date b/c I didnt have it on my galacticon's asdf listing. Its possible that is still the best version to use though; I didn't spend that much time sussing this out
There was a problem hiding this comment.
Yeah what's funny @electricshaman is that this is controlled somewhere in harness or maybe another dependency. I was editing the mix.exs directly and bypassing harness in agora to test my change. I haven't gotten far enough to see where I would bump the version to take advantage of this but this is not a huge advantageous change that would be urgent for consumers to adopt so maybe its OK to bump elixir version a bit? I'm not sure how to reason about it.
There was a problem hiding this comment.
@jnmandal First thing that popped into my head was to search for Elixir 1.9 versions (or lower) either in mix.exs directly or harness.exs across NFIBrokerage and see what that list looks like.
There was a problem hiding this comment.
but we can check on invoice_emailing_pm that is harnessed on an older harness pm version (cause of wkhtml2pdf) and runs on elixir 1.11
There was a problem hiding this comment.
harness itself is on elixir 1.11.0-otp-22
erlang 22.3
There was a problem hiding this comment.
I can yeet an RC for bless with this updated elixir and see if harness complains ¯_(ツ)_/¯
There was a problem hiding this comment.
TBH I am fine with rolling it back to 1.10. The only reason I chose 1.14 was because I didn't want to download another version into my asdf and in hindsight that seems like a poor reason to bump versions
There was a problem hiding this comment.
yup, works in harness on 1.11 with RC from this branch. I just have PR that makes sure that we can publish a hex package with RC in the name
tonyvanriet
left a comment
tonyvanriet
left a comment
There was a problem hiding this comment.
tyty
coulda swore I had successfully used seed with bless before... maybe that was an earlier incarnation that was not this library. anyway, thx <3
Think this was when we first added the cool color highlighting and stuff. It did used to work! But then I think one of the sub tasks started erroring when we passed unknown args. |
|
close in favor of #11 |
Goal here is to be able to run
mix bless --seed 12345and have it work intuitively. Tried to keep the code in a way where different args could be added easily later if we decide there are more we care about. Unfortunately its not possible to pass through all the args as some of the tasks will fail w/ unknown args.connect #8