Skip to content

WAL-3164: Remove "reason" as filter for transactions/find #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pedro-bruno-cc wants to merge 5 commits into
base: master
Choose a base branch
from
Open

WAL-3164: Remove "reason" as filter for transactions/find #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
386b482
WAL-3164: Remove "reason" as filter for transactions/find
pedro-bruno-cc Feb 5, 2025
82c904e
WAL-3164: Remove reference from Client
pedro-bruno-cc Feb 7, 2025
ef6bd6b
Revert "WAL-3164: Remove reference from Client"
pedro-bruno-cc Feb 18, 2025
e526581
Revert "WAL-3164: Remove "reason" as filter for transactions/find"
pedro-bruno-cc Feb 18, 2025
2529dd1
WAL-3164: Mark as deprecated the "reason" as filter for transactions/…
pedro-bruno-cc Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/currencycloud/client/CurrencyCloud.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1468,7 +1468,7 @@ Transactions findTransactions(
@Nullable @QueryParam("related_entity_short_reference") String relatedEntityShortReference,
@Nullable @QueryParam("status") String status,
@Nullable @QueryParam("type") String type,
@Nullable @QueryParam("reason") String reason,
@Deprecated @Nullable @QueryParam("reason") String reason,
@Nullable @QueryParam("settles_at_from") java.sql.Date settlesAtFrom,
@Nullable @QueryParam("settles_at_to") java.sql.Date settlesAtTo,
@Nullable @QueryParam("created_at_from") java.sql.Date createdAtFrom,
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/currencycloud/client/CurrencyCloudClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1437,7 +1437,7 @@ public Transactions findTransactions(@Nullable Transaction transaction, @Nullabl
transaction.getRelatedEntityShortReference(),
transaction.getStatus(),
transaction.getType(),
transaction.getReason(),
transaction.getReason(), /* Deprecated */
dateOnly(transaction.getSettlesAtFrom()),
dateOnly(transaction.getSettlesAtTo()),
dateOnly(transaction.getCreatedAtFrom()),
Expand Down