Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes an important change to how the materialized view name is passed and handled in the workflow for refreshing materialized views. The view name is now explicitly injected as an environment variable, and the Python script requires this variable to be set, improving clarity and error handling.
Workflow template improvements:
VIEW_NAMEenvironment variable in the Kubernetes workflow template, using the input parameterview_name. (k8s/welearn-datastack/templates/updateMaterializedViews/workflow-template-refresh-materialized-views.yaml)Python script robustness:
VIEW_NAMEinupdate_materialized_view.pytoNoneinstead of a specific view name, and added error handling to require the environment variable to be set. (welearn_datastack/nodes_workflow/UpdateMaterializedView/update_materialized_view.py)