Skip to content

Conversation

@wagyourtail
Copy link

@wagyourtail wagyourtail commented Feb 9, 2025

this is very cursed code... could probably be done a little better with a IDependencyLocator that actually just checks if graalvm and then conditionally loads the deps. but this is 100x easier to write.

why doesn't neo just have a way to do this in jarjar.

(maybe don't merge yet...)
also, I haven't fully tested it, just the testscript command

@CLAassistant
Copy link

CLAassistant commented Feb 9, 2025

CLA assistant check
All committers have signed the CLA.

@wagyourtail
Copy link
Author

hopefully neoforged/JarJar#5 will result in a better solution

@rubensworks
Copy link
Member

Thanks @wagyourtail!
I'll try to have a detailed look at this in the near future.

@rubensworks
Copy link
Member

Thanks for going through this effort @wagyourtail!

The code is however a bit too cursed for my taste 😅

I did however see that Graal has made changes that may fix the shadow issues. So I'll await the next Graal release, and try to make it work that way.

@rubensworks rubensworks moved this from To Do (Minor) to Done in Maintenance Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants